docs: clarify scriptLoading behavior for existing script tags#6358
Merged
chenjiahan merged 2 commits intomainfrom Oct 14, 2025
Merged
docs: clarify scriptLoading behavior for existing script tags#6358chenjiahan merged 2 commits intomainfrom
chenjiahan merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR clarifies the behavior of the scriptLoading configuration option in Rsbuild documentation by explicitly stating it only affects automatically generated script tags, not existing ones in HTML templates or those added via configuration APIs.
- Added documentation sections explaining the scope limitations of
scriptLoading - Created test cases to verify that existing script tags remain unchanged
- Added tests for both HTML template scripts and
html.tagsconfigured scripts
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| website/docs/en/config/html/script-loading.mdx | Added English documentation clarifying scriptLoading scope limitations |
| website/docs/zh/config/html/script-loading.mdx | Added Chinese documentation clarifying scriptLoading scope limitations |
| e2e/cases/html/script-loading/src/index.html | Created HTML template with existing script tag for testing |
| e2e/cases/html/script-loading/index.test.ts | Added test cases verifying scriptLoading behavior with existing scripts |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
scriptLoadingoption only affects Rsbuild-generated script tags, not existing ones in HTML template or added viahtml.tags/modifyHtmlTags.Checklist