feat(create-rsbuild): enable ts check for JS config files#6353
Merged
chenjiahan merged 1 commit intomainfrom Oct 14, 2025
Merged
feat(create-rsbuild): enable ts check for JS config files#6353chenjiahan merged 1 commit intomainfrom
chenjiahan merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds TypeScript checking to JavaScript configuration files in create-rsbuild templates by adding the // @ts-check directive to all JS template config files.
- Adds
// @ts-checkcomment to all JavaScript rsbuild.config.mjs files - Enables TypeScript type checking for JavaScript configuration files
- Helps users identify invalid configurations early in development
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/create-rsbuild/template-vue3-js/rsbuild.config.mjs | Added // @ts-check directive for TypeScript checking |
| packages/create-rsbuild/template-vue2-js/rsbuild.config.mjs | Added // @ts-check directive for TypeScript checking |
| packages/create-rsbuild/template-vanilla-js/rsbuild.config.mjs | Added // @ts-check directive for TypeScript checking |
| packages/create-rsbuild/template-svelte-js/rsbuild.config.mjs | Added // @ts-check directive for TypeScript checking |
| packages/create-rsbuild/template-solid-js/rsbuild.config.mjs | Added // @ts-check directive for TypeScript checking |
| packages/create-rsbuild/template-react18-js/rsbuild.config.mjs | Added // @ts-check directive for TypeScript checking |
| packages/create-rsbuild/template-react-js/rsbuild.config.mjs | Added // @ts-check directive for TypeScript checking |
| packages/create-rsbuild/template-preact-js/rsbuild.config.mjs | Added // @ts-check directive for TypeScript checking |
| packages/create-rsbuild/template-lit-js/rsbuild.config.mjs | Added // @ts-check directive for TypeScript checking |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Enable TypeScript check for JS config files in templates, helping users to identify invalid configurations.
Links
https://www.typescriptlang.org/docs/handbook/intro-to-js-ts.html#ts-check
Checklist