Skip to content

feat(create-rsbuild): enable ts check for JS config files#6353

Merged
chenjiahan merged 1 commit intomainfrom
ts_check_1013
Oct 14, 2025
Merged

feat(create-rsbuild): enable ts check for JS config files#6353
chenjiahan merged 1 commit intomainfrom
ts_check_1013

Conversation

@chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Oct 13, 2025

Summary

Enable TypeScript check for JS config files in templates, helping users to identify invalid configurations.

Screenshot 2025-10-13 at 22 23 42

Links

https://www.typescriptlang.org/docs/handbook/intro-to-js-ts.html#ts-check

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings October 13, 2025 14:25
@netlify
Copy link

netlify bot commented Oct 13, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 1731318
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/68ed0bce608a3a000825587c
😎 Deploy Preview https://deploy-preview-6353--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 65 (🔴 down 13 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds TypeScript checking to JavaScript configuration files in create-rsbuild templates by adding the // @ts-check directive to all JS template config files.

  • Adds // @ts-check comment to all JavaScript rsbuild.config.mjs files
  • Enables TypeScript type checking for JavaScript configuration files
  • Helps users identify invalid configurations early in development

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/create-rsbuild/template-vue3-js/rsbuild.config.mjs Added // @ts-check directive for TypeScript checking
packages/create-rsbuild/template-vue2-js/rsbuild.config.mjs Added // @ts-check directive for TypeScript checking
packages/create-rsbuild/template-vanilla-js/rsbuild.config.mjs Added // @ts-check directive for TypeScript checking
packages/create-rsbuild/template-svelte-js/rsbuild.config.mjs Added // @ts-check directive for TypeScript checking
packages/create-rsbuild/template-solid-js/rsbuild.config.mjs Added // @ts-check directive for TypeScript checking
packages/create-rsbuild/template-react18-js/rsbuild.config.mjs Added // @ts-check directive for TypeScript checking
packages/create-rsbuild/template-react-js/rsbuild.config.mjs Added // @ts-check directive for TypeScript checking
packages/create-rsbuild/template-preact-js/rsbuild.config.mjs Added // @ts-check directive for TypeScript checking
packages/create-rsbuild/template-lit-js/rsbuild.config.mjs Added // @ts-check directive for TypeScript checking

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@chenjiahan chenjiahan merged commit 8dd6c30 into main Oct 14, 2025
13 checks passed
@chenjiahan chenjiahan deleted the ts_check_1013 branch October 14, 2025 02:32
@chenjiahan chenjiahan mentioned this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments