perf: reduce stats.hasErrors() calls - #6305
Merged
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes build performance by replacing stats.hasErrors() method calls with direct access to context.buildState.hasErrors property, reducing overhead during build error checking.
- Replaced
stats.hasErrors()calls withcontext.buildState.hasErrorsacross build providers - Updated
pluginFileSizeto acceptInternalContextparameter for accessing build state - Modified plugin initialization to pass context to
pluginFileSize
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/provider/build.ts | Replaced stats method call with direct build state access |
| packages/core/src/plugins/fileSize.ts | Updated plugin to accept context parameter and use build state |
| packages/core/src/createRsbuild.ts | Modified plugin initialization to pass context |
| packages/compat/webpack/src/build.ts | Replaced stats method call with direct build state access |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
context.buildState.hasErrorsinstead ofstats.hasErrors(), which will reduce the overhead slightly.Checklist