Skip to content

perf(hmr): no need to get assets info #6296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 2 commits into from
Oct 2, 2025
Merged

perf(hmr): no need to get assets info #6296

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fea728
perf(hmr): no need to get assets info
chenjiahan Oct 1, 2025
f711885
Apply suggestion from @Copilot
chenjiahan Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 19 additions & 16 deletions packages/core/src/server/socketServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ export class SocketServer {

private reportedBrowserLogs: Set<string> = new Set();

private currentHash: Map<string, string> = new Map();

constructor(
context: InternalContext,
options: DevConfig,
Expand Down Expand Up @@ -332,10 +334,9 @@ export class SocketServer {
return null;
}

const defaultStats: Record<string, boolean> = {
const defaultStats: Rspack.StatsOptions = {
all: false,
hash: true,
assets: true,
warnings: true,
warningsCount: true,
errors: true,
Expand Down Expand Up @@ -383,7 +384,7 @@ export class SocketServer {
const newInitialChunks: Set<string> = new Set();
if (statsJson.entrypoints) {
for (const entrypoint of Object.values(statsJson.entrypoints)) {
const chunks = entrypoint.chunks;
const { chunks } = entrypoint;

if (!Array.isArray(chunks)) {
continue;
Expand Down Expand Up @@ -411,19 +412,22 @@ export class SocketServer {
return;
}

const shouldEmit =
!force &&
statsJson &&
!statsJson.errorsCount &&
statsJson.assets &&
statsJson.assets.every((asset: any) => !asset.emitted);

if (shouldEmit) {
this.sockWrite({ type: 'ok' }, token);
return;
}

if (statsJson.hash) {
const prevHash = this.currentHash.get(token);
this.currentHash.set(token, statsJson.hash);

// If build hash is not changed and there is no error or warning, skip emit
const shouldEmit =
!force &&
!statsJson.errorsCount &&
!statsJson.warningsCount &&
prevHash === statsJson.hash;
Comment thread
chenjiahan marked this conversation as resolved.

if (shouldEmit) {
this.sockWrite({ type: 'ok' }, token);
return;
}

this.sockWrite(
{
type: 'hash',
Expand Down Expand Up @@ -469,7 +473,6 @@ export class SocketServer {
}

this.sockWrite({ type: 'ok' }, token);
return;
}

// send message to connecting socket
Expand Down
Loading