fix: remove the deprecated url.parse from historyApiFallback
#5696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
chenjiahan
commented
Jul 28, 2025
|
|
||
| export type HistoryApiFallbackTo = | ||
| | string | ||
| | RegExp |
There was a problem hiding this comment.
Remove the invalid type, see https://github.com/bripkens/connect-history-api-fallback/blob/main/lib/index.js#L93
chenjiahan
changed the title
url.parseurl.parse from historyApiFallback
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
url.parsehas been deprecated since Node 24, and we should usenew URLinstead.Related Links
TODO
We still have three dependencies that use
url.parse:Checklist