feat: validate output target in Rsbuild config

[chenjiahan]

Summary

Validate the output.target in the Rsbuild config to detect configuration errors at an earlier stage.

Checklist

• Tests updated (or not required).
• Documentation updated (or not required).

[netlify]

✅ Deploy Preview for rsbuild ready!

Name	Link
🔨 Latest commit	55eb005
🔍 Latest deploy log	https://app.netlify.com/projects/rsbuild/deploys/68750700ae93740008021d96
😎 Deploy Preview	https://deploy-preview-5592--rsbuild.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 81 (🟢 up 8 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 100 (no change from production) PWA: 60 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[Copilot]

Pull Request Overview

This PR adds early validation for the output.target setting in Rsbuild configurations and updates E2E scripts to normalize error messages and cover invalid-target scenarios.

• Refactored environment name checks and introduced per-environment output.target validation in initConfigs.ts.
• Stripped ANSI control characters from caught build errors in shared E2E scripts.
• Added a new E2E case for invalid output.target.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
packages/core/src/provider/initConfigs.ts	Refactor config.environments guard and add output.target validation
e2e/scripts/shared.ts	Import and apply stripVTControlCharacters to sanitize error messages
e2e/cases/output/invalid-target/exports-presence/src/index.js	Add placeholder entry point for invalid-target test
e2e/cases/output/invalid-target/exports-presence/index.test.ts	Add Playwright test for invalid output.target error

Comments suppressed due to low confidence (4)

e2e/cases/output/invalid-target/exports-presence/index.test.ts:4

• [nitpick] The test name references an "exportsPresence" error but is actually validating an invalid output.target. Rename it to something like should throw for invalid output.target for clarity.

test('should throw error by default (exportsPresence error)', async () => {

e2e/cases/output/invalid-target/exports-presence/index.test.ts:16

• Consider adding a complementary test case that uses valid targets (web, node, web-worker) to ensure no error is thrown when the value is correct.

  expect(rsbuild.buildError?.message).toContain(

packages/core/src/provider/initConfigs.ts:184

• If output.target can also be provided at the top level (outside environments), this early return will skip its validation. Consider validating config.output?.target before returning or clearly documenting that root-level targets must go under environments.

  if (!config.environments) {

packages/core/src/provider/initConfigs.ts:199

• Directly accessing output without checking for its existence may throw if an environment has no output block. Add a guard (e.g. const outputConfig = config.environments[name].output || {};) or use optional chaining.

    const outputConfig = config.environments[name].output;

[cursor]

Bug: Undefined `outputConfig` Causes Target Access Error

The validateRsbuildConfig function attempts to access outputConfig.target without ensuring outputConfig is defined. If config.environments[name].output is missing or undefined, this results in a TypeError "Cannot read property 'target' of undefined".

packages/core/src/provider/initConfigs.ts#L199-L201

rsbuild/packages/core/src/provider/initConfigs.ts

Lines 199 to 201 in 55eb005

	const outputConfig = config.environments[name].output;
	if (outputConfig.target) {

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎