Skip to content

Conversation

@thinkasany
Copy link
Contributor

Summary

Maybe it is also a good practice to specify the relative path of the @biomejs/biome package. I searched many repositories in github that use this method. The advantage of doing this is that there is no need to manually update the corresponding version.

image
image

Related Links

https://biomejs.dev/reference/configuration/#schema

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings June 25, 2025 05:58
@netlify
Copy link

netlify bot commented Jun 25, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 974f47f
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/685b8ffa66987800081d0690
😎 Deploy Preview https://deploy-preview-5482--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 75 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the schema reference in the biome.json configuration file to use a relative path within the @biomejs/biome package. This approach helps avoid manual version updates and aligns with practices observed in other repositories.

  • Updated the $schema property in biome.json from an external URL to a relative path.
  • The change aims to automatically match the package version.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chenjiahan chenjiahan merged commit 6a0fa14 into web-infra-dev:main Jun 25, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants