Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

This pull request introduces enhancements to the ModifyChainUtils type and updates related documentation. The changes add new JSDoc to the type and refine the documentation for clarity and consistency.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings June 24, 2025 14:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the documentation for environment and target contexts by refining descriptions and examples in both Chinese and English docs, and by adding detailed JSDoc comments to the ModifyChainUtils type.

  • Updates explanatory texts for development and production build conditions.
  • Refines target environment descriptions with practical configuration examples.
  • Enhances the ModifyChainUtils type documentation with additional properties and detailed comments.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
website/docs/zh/config/tools/rspack.mdx Clarified boolean descriptions and target configuration examples.
website/docs/zh/config/tools/bundler-chain.mdx Updated documentation with example code but introduced a method name change.
website/docs/en/config/tools/rspack.mdx Enhanced descriptions and examples in English.
website/docs/en/config/tools/bundler-chain.mdx Updated explanatory texts with a potential method name change.
packages/core/src/types/hooks.ts Added detailed JSDoc comments to the ModifyChainUtils type.
Comments suppressed due to low confidence (2)

website/docs/zh/config/tools/bundler-chain.mdx:101

  • The method name was changed from 'bundlerChain' to 'rspack' in this documentation. Please verify that this change aligns with the actual API and update any inconsistent references if needed.
    rspack: (config, { target }) => {

website/docs/en/config/tools/bundler-chain.mdx:101

  • The method name was changed from 'bundlerChain' to 'rspack' in this documentation. Please verify that this change reflects the intended API usage and update related references accordingly.
    rspack: (config, { target }) => {

@netlify
Copy link

netlify bot commented Jun 24, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit a0d5057
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/685b5af281f7e30008245c56
😎 Deploy Preview https://deploy-preview-5478--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 76 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@chenjiahan chenjiahan merged commit ba78452 into main Jun 25, 2025
11 checks passed
@chenjiahan chenjiahan deleted the env_doc_0624 branch June 25, 2025 02:19
@chenjiahan chenjiahan mentioned this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant