perf: disable bundler info injection #5476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR disables the default BundlerInfo injection in Rspack to reduce bundle size.
- Adds
rspackFuture.bundlerInfo.force = falsein the basic plugin when using Rspack - Updates snapshot tests across environments, default, builder, and basic suites to include the new experiments block
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/plugins/basic.ts | Inject rspackFuture.bundlerInfo.force = false when bundler is Rspack |
| packages/core/tests/__snapshots/environments.test.ts.snap | Added default rspackFuture.bundlerInfo in snapshots |
| packages/core/tests/__snapshots/default.test.ts.snap | Added default rspackFuture.bundlerInfo in snapshots |
| packages/core/tests/__snapshots/builder.test.ts.snap | Added default rspackFuture.bundlerInfo in snapshots |
| packages/core/tests/__snapshots/basic.test.ts.snap | Added default rspackFuture.bundlerInfo in snapshots |
Comments suppressed due to low confidence (2)
packages/core/src/plugins/basic.ts:94
- Add unit tests to verify behavior when
rspackFuture.bundlerInfo.forceis set totrueorfalse, ensuring that injection is correctly applied or omitted in each case.
if (api.context.bundlerType === 'rspack') {
packages/core/src/plugins/basic.ts:96
- [nitpick] Spreading
chain.get('experiments')performs a shallow merge of experiment flags. Consider using a deep-merge utility orchain.mergeto preserve nested experiment settings correctly.
...chain.get('experiments'),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR disables the default bundler info injection to reduce bundle size. This removes the Rspack version information from the bundle code and is not noticeable to users.
Related Links
bundlerInfo.forceis false rspack#10783Checklist