Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

Fix a regression introduced by #5431

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings June 19, 2025 10:42
@netlify
Copy link

netlify bot commented Jun 19, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 3e7ec45
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/6853e97a717bf200085757f7
😎 Deploy Preview https://deploy-preview-5447--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 71 (🟢 up 15 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a regression in the lazy compilation plugin by streamlining the control flow to ensure lazy compilation is enabled correctly.

  • Added an early return to skip further configuration when only imports are enabled
  • Removed the old else block and unindented the main experiments call for clarity
Comments suppressed due to low confidence (1)

packages/core/src/plugins/lazyCompilation.ts:32

  • Add a unit test for the case when options.imports is true to verify that lazyCompilation is skipped as intended by the early return.
          return;

@chenjiahan chenjiahan merged commit c949025 into main Jun 19, 2025
12 checks passed
@chenjiahan chenjiahan deleted the enable_lazy_0619 branch June 19, 2025 10:48
This was referenced Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant