Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

Deleted the fix-react-refresh-in-rsbuild plugin, which was a temporary solution to address HMR issues with the css-loader. This cleanup simplifies the codebase and removes a workaround specific to the repository.

Related Links

web-infra-dev/rspack#5723

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings June 18, 2025 07:20
@netlify
Copy link

netlify bot commented Jun 18, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit c1f616f
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/685268ce1700830008faf8ad
😎 Deploy Preview https://deploy-preview-5438--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 75 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes a temporary plugin used to patch HMR issues with the CSS loader and cleans up an unused type import and option.

  • Remove the fix-react-refresh-in-rsbuild plugin hook from the dev script
  • Delete the unused LogLevel import and logLevel option in console helper

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
e2e/scripts/shared.ts Removed temporary HMR workaround plugin setup
e2e/scripts/helper.ts Deleted unused LogLevel import and logLevel field
Comments suppressed due to low confidence (2)

e2e/scripts/helper.ts:79

  • Ensure there are no remaining references to logLevel in the codebase or tests—remove or update them to avoid lingering type errors.
  keepAnsi?: boolean;

@chenjiahan chenjiahan merged commit 5abf92d into main Jun 18, 2025
12 checks passed
@chenjiahan chenjiahan deleted the remove_temp_plugin_0618 branch June 18, 2025 07:29
This was referenced Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant