Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades Biome to v2, migrates the configuration, and resolves all new lint issues across e2e test cases and project configs.
- Updated
biome.jsonschema and lint rule definitions - Organized and reordered imports, removed unused React imports in legacy JSX cases
- Added/removed error-handling and blank lines to satisfy new lint rules
Reviewed Changes
Copilot reviewed 88 out of 88 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| e2e/cases/plugin-react/legacy-jsx/src/App.jsx | Added // biome-ignore for unused React import |
| e2e/cases/plugin-react/enable-profiler/src/App.jsx | Removed unused React import |
| e2e/cases/plugin-api/plugin-hooks/index.test.ts | Reordered createRsbuild and type RsbuildPlugin imports |
| e2e/cases/plugin-api/plugin-hooks-watch/index.test.ts | Reordered createRsbuild and type RsbuildPlugin imports |
| e2e/cases/plugin-api/plugin-hooks-environment/index.test.ts | Reordered createRsbuild and type RsbuildPlugin imports |
| e2e/cases/plugin-api/plugin-expose/index.test.ts | Reordered createRsbuild and type RsbuildPlugin imports |
| e2e/cases/plugin-api/plugin-after-build-hook/index.test.ts | Reordered createRsbuild and type RsbuildPlugin imports |
| e2e/cases/node-polyfill-tip/without-protocol/index.test.ts | Changed catch (err) {} to catch {} |
| e2e/cases/node-polyfill-tip/with-protocol/index.test.ts | Changed catch (err) {} to catch {} |
| e2e/cases/module/glob-import/src/App.jsx | Removed unused useState import and variable |
| e2e/cases/module-federation/remote/src/bootstrap.js | Removed unused React import |
| e2e/cases/module-federation/host/src/bootstrap.js | Removed unused React import |
| e2e/cases/module-federation-v2/remote/src/bootstrap.js | Removed unused React import |
| e2e/cases/module-federation-v2/host/src/bootstrap.js | Removed unused React import |
| e2e/cases/html/template-with-script/index.test.ts | Added // biome-ignore for template‐string lint |
| e2e/cases/css/css-assets/index.test.ts | Combined helper imports into a single statement |
| e2e/cases/cli/watch-files/rsbuild.config.ts | Reordered defineConfig and type RsbuildPlugin imports |
| e2e/cases/cli/watch-files-array/rsbuild.config.ts | Reordered defineConfig and type RsbuildPlugin imports |
| e2e/cases/assets/emit-assets/src/index.js | Inserted blank line for import separation |
| biome.json | Updated to v2 schema, reorganized assist.actions, added new lint rules |
Comments suppressed due to low confidence (2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
npx @biomejs/biome migrate --writeto migrate the configRelated Links
https://biomejs.dev/blog/biome-v2/
Checklist