Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

  • Export LogLevel type from core
  • Update rslog to v1.2.7

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings June 17, 2025 09:26
@netlify
Copy link

netlify bot commented Jun 17, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 9ca5308
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/685134d3a8576b0008159506
😎 Deploy Preview https://deploy-preview-5435--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 75 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR exposes the existing LogLevel type from the core package and upgrades the rslog dependency to v1.2.7.

  • Export LogLevel in the core type exports
  • Bump rslog dependency version to ^1.2.7

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
packages/core/src/index.ts Added LogLevel to the exported type list
packages/core/package.json Updated rslog dependency from ^1.2.6 to ^1.2.7
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)

packages/core/src/index.ts:81

  • Consider updating the public API documentation (e.g., README or typedocs) to mention the newly-exported LogLevel type so consumers know it's available.
LogLevel,

packages/core/package.json:91

  • You bumped the rslog dependency version—don't forget to commit the updated lockfile (e.g., yarn.lock or package-lock.json) to keep installs reproducible.
"rslog": "^1.2.7",

@chenjiahan chenjiahan merged commit f563a64 into main Jun 17, 2025
12 checks passed
@chenjiahan chenjiahan deleted the log_level_type_0617 branch June 17, 2025 09:38
This was referenced Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant