fix: ensure log level can work for all logs #5434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the log level handling in the CLI to ensure that the logger’s level is set before any logs are printed based on the provided command‐line flag.
- Added logic in runCLI to process the --log-level flag and update the logger’s level appropriately.
- Updated end-to-end tests to strip ANSI control characters from log outputs and verify correct log behavior for "info" and "warn" levels.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/cli/index.ts | Added flag parsing logic to set the logger level before any log is printed. |
| e2e/cases/cli/log-level/index.test.ts | Updated tests to handle ANSI output and validate log behavior for different levels. |
Comments suppressed due to low confidence (2)
packages/core/src/cli/index.ts:24
- Consider providing user feedback (such as a warning message) or a default fallback when an unsupported log level is provided to help clarify behavior.
if (logLevelIndex !== -1) {
e2e/cases/cli/log-level/index.test.ts:6
- Consider adding a test case for an unsupported log level to ensure the logger maintains the expected default behavior when an invalid option is passed.
rspackOnlyTest('should run build command with log level: info', async () => {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added logic to parse
--log-levelflag in therunCLIfunction, ensuring the log level is set (warn,error, orsilent) before any logs are printed.Related Links
#5194
Checklist