feat(CLI): add --logLevel flag #5433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new --log-level flag for the Rsbuild CLI to allow users to control the verbosity of logs. The changes include documentation updates (both English and Chinese guides), new type definitions for log levels in the configuration, and updates in the CLI initialization and command registration logic, along with corresponding tests.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| website/docs/zh/guide/basic/cli.mdx | Added documentation for the new --log-level flag |
| website/docs/en/guide/basic/cli.mdx | Added documentation for the new --log-level flag |
| packages/core/src/types/config.ts | Introduced LogLevel type and updated RsbuildConfig |
| packages/core/src/cli/init.ts | Integrated logLevel option into the CLI configuration |
| packages/core/src/cli/commands.ts | Registered --log-level flag in the command options |
| e2e/cases/cli/log-level/src/index.js | Added a basic log output for test purposes |
| e2e/cases/cli/log-level/index.test.ts | Added tests to verify the behavior of the log level flag |
Comments suppressed due to low confidence (1)
e2e/cases/cli/log-level/index.test.ts:6
- The test uses '--logLevel' (camel case) which is inconsistent with the defined and documented flag '--log-level'. Please update the test to match the flag naming for consistency.
const result = execSync('npx rsbuild build --logLevel info', {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a new
--log-levelflag to the Rsbuild CLI, allowing users to specify the verbosity of logs (info,warn,error, orsilent).Checklist