Skip to content

feat(deps): update @rspack/core to 1.4.0-beta.1#5429

Merged
chenjiahan merged 2 commits intomainfrom
update_rspack_0617
Jun 17, 2025
Merged

feat(deps): update @rspack/core to 1.4.0-beta.1#5429
chenjiahan merged 2 commits intomainfrom
update_rspack_0617

Conversation

@chenjiahan
Copy link
Member

Summary

Update @rspack/core to 1.4.0-beta.1 and adapt the latest the lazy compilation usage.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings June 17, 2025 03:29
@netlify
Copy link

netlify bot commented Jun 17, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit b12d95b
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/6850e10e5982c80008e232a6
😎 Deploy Preview https://deploy-preview-5429--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 73 (🔴 down 20 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (🟢 up 8 from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates @rspack/core to version 1.4.0-beta.1 and adapts the lazy compilation integration by removing the old middleware argument and adding a dedicated plugin.

  • Bump @rspack/core dependency to 1.4.0-beta.1
  • Remove deprecated dev.lazyCompilation argument from lazyCompilationMiddleware
  • Introduce and register pluginLazyCompilation to configure the experiment via the bundler chain

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
packages/core/src/server/devMiddlewares.ts Removed passing of dev.lazyCompilation argument to the middleware
packages/core/src/plugins/lazyCompilation.ts Added pluginLazyCompilation to apply the lazyCompilation experiment
packages/core/src/createRsbuild.ts Registered pluginLazyCompilation in the default plugin list
packages/core/package.json Updated @rspack/core version to 1.4.0-beta.1
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)

packages/core/src/server/devMiddlewares.ts:148

  • The lazyCompilationMiddleware signature has changed in v1.4.0-beta.1 and no longer accepts the lazyCompilation options as a third argument. Update this call to use the new API (e.g., pass options via an options object or chain configuration).
dev.lazyCompilation,

packages/core/src/plugins/lazyCompilation.ts:3

  • Add unit tests covering pluginLazyCompilation to verify that it correctly applies the lazyCompilation experiment when config.dev.lazyCompilation is set.
export const pluginLazyCompilation = (): RsbuildPlugin => ({

@chenjiahan chenjiahan merged commit 7e0522e into main Jun 17, 2025
10 of 12 checks passed
@chenjiahan chenjiahan deleted the update_rspack_0617 branch June 17, 2025 03:33
@chenjiahan chenjiahan mentioned this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant