feat(deps): update @rspack/core to 1.4.0-beta.1#5429
Merged
chenjiahan merged 2 commits intomainfrom Jun 17, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates @rspack/core to version 1.4.0-beta.1 and adapts the lazy compilation integration by removing the old middleware argument and adding a dedicated plugin.
- Bump
@rspack/coredependency to1.4.0-beta.1 - Remove deprecated
dev.lazyCompilationargument fromlazyCompilationMiddleware - Introduce and register
pluginLazyCompilationto configure the experiment via the bundler chain
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/server/devMiddlewares.ts | Removed passing of dev.lazyCompilation argument to the middleware |
| packages/core/src/plugins/lazyCompilation.ts | Added pluginLazyCompilation to apply the lazyCompilation experiment |
| packages/core/src/createRsbuild.ts | Registered pluginLazyCompilation in the default plugin list |
| packages/core/package.json | Updated @rspack/core version to 1.4.0-beta.1 |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
packages/core/src/server/devMiddlewares.ts:148
- The
lazyCompilationMiddlewaresignature has changed in v1.4.0-beta.1 and no longer accepts the lazyCompilation options as a third argument. Update this call to use the new API (e.g., pass options via an options object or chain configuration).
dev.lazyCompilation,
packages/core/src/plugins/lazyCompilation.ts:3
- Add unit tests covering
pluginLazyCompilationto verify that it correctly applies thelazyCompilationexperiment whenconfig.dev.lazyCompilationis set.
export const pluginLazyCompilation = (): RsbuildPlugin => ({
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Update @rspack/core to 1.4.0-beta.1 and adapt the latest the lazy compilation usage.
Related Links
Checklist