Skip to content

fix: dont redirect rsbuild.dev#5428

Merged
chenjiahan merged 1 commit intomainfrom
fix/dont_redirect_rsbuild.dev
Jun 17, 2025
Merged

fix: dont redirect rsbuild.dev#5428
chenjiahan merged 1 commit intomainfrom
fix/dont_redirect_rsbuild.dev

Conversation

@stormslowly
Copy link
Contributor

Summary

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings June 17, 2025 02:16
@netlify
Copy link

netlify bot commented Jun 17, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 05b3b34
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/6850cff152d83a0008ac545f
😎 Deploy Preview https://deploy-preview-5428--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 91 (🟢 up 8 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the redirection rule for rsbuild.dev from netlify.toml to stop redirecting users from that domain and instead provides a catch-all redirect to a 404 page.

  • Removed the custom redirection from rsbuild.dev to rsbuild.rs
  • Retained a catch-all redirect directing all other paths to /404.html
Comments suppressed due to low confidence (1)

website/docs/public/netlify.toml:1

  • [nitpick] Consider adding a comment or updating the commit message to document the rationale behind removing the rsbuild.dev redirection rule, which can aid future maintainers in understanding this change.
-# Redirect rsbuild.dev to rsbuild.rs

@chenjiahan chenjiahan enabled auto-merge (squash) June 17, 2025 02:17
@chenjiahan chenjiahan disabled auto-merge June 17, 2025 02:18
@chenjiahan chenjiahan merged commit 40cd6d0 into main Jun 17, 2025
12 checks passed
@chenjiahan chenjiahan deleted the fix/dont_redirect_rsbuild.dev branch June 17, 2025 02:18
@chenjiahan chenjiahan mentioned this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants