Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

Adds cleanup logic to E2E tests, use the test.afterAll hooks to clean up test artifacts.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings June 15, 2025 12:18
@netlify
Copy link

netlify bot commented Jun 15, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit fbc479f
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/684eba089a7e610008a0973c
😎 Deploy Preview https://deploy-preview-5422--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 49 (🔴 down 23 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds cleanup logic to E2E tests that removes temporary files generated during test runs.

  • Adds a test.afterAll hook in the rspack profile tests to remove files beginning with ".rspack-profile".
  • Adds a test.afterAll hook in the config inspect tests to remove directories starting with "test-temp" or "dist".

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
e2e/cases/rspack-profile/index.test.ts Added afterAll cleanup logic to remove temporary rspack profile files.
e2e/cases/config/inspect-config/index.test.ts Added afterAll cleanup logic to remove directories beginning with "test-temp" or "dist".

@chenjiahan chenjiahan merged commit eea0b2d into main Jun 15, 2025
12 checks passed
@chenjiahan chenjiahan deleted the e2e_cleanup_0615 branch June 15, 2025 12:25
@chenjiahan chenjiahan mentioned this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant