Skip to content

Conversation

@chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Jun 12, 2025

Summary

  • Update @rspack/core to v1.4.0-beta.0
  • Update tracing logic to match the latest Rspack implementation

Related Links

https://github.com/web-infra-dev/rspack/releases/tag/v1.4.0-beta.0

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings June 12, 2025 15:19
@netlify
Copy link

netlify bot commented Jun 12, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 6c6c756
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/684aeffa236f080008d6b8c8
😎 Deploy Preview https://deploy-preview-5407--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 78 (🟢 up 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the @rspack/core dependency to v1.4.0-beta.0 and aligns related functionalities.

  • Added the new dictionary entry "pftrace" to support the updated trace output naming.
  • Applied a type assertion change for the default middleware and updated the trace layer handling in rspackProfile.ts to use "perfetto" instead of "chrome".
  • Updated the package.json dependency version accordingly.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
scripts/dictionary.txt Added new entry "pftrace" for updated trace naming support.
packages/core/src/server/devMiddlewares.ts Added a type assertion cast to RequestHandler for middleware.
packages/core/src/plugins/rspackProfile.ts Changed default traceLayer from "chrome" to "perfetto" and updated output file naming.
packages/core/package.json Updated @rspack/core dependency version to v1.4.0-beta.0.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@chenjiahan chenjiahan merged commit 1b18449 into main Jun 12, 2025
13 checks passed
@chenjiahan chenjiahan deleted the update_rspack__0612 branch June 12, 2025 23:06
@chenjiahan chenjiahan mentioned this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant