test(e2e): proxy SRI plugin warning log #5403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates an end-to-end test for the dev build to proxy console logs and verify that distracting SRI plugin warning logs are properly captured.
- Added import and usage of proxyConsole to capture logs.
- Asserted that the warning message is present in the captured logs.
- Restored the console after the test completes.
| ), | ||
| ).toBe(true); | ||
|
|
||
| restore(); |
There was a problem hiding this comment.
Consider wrapping the test assertions and restore() in a try...finally block to ensure that restore() is always called, even if an assertion fails.
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Proxy SRI plugin warning log to reduce distracting information.
Checklist