chore: remove baseUrl option from tsconfig #5401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the now-unused baseUrl option from various e2e test case tsconfig.json files to align with its planned removal in the shared config.
- Bulk removal of
baseUrlentries from all relevant e2etsconfig.jsonfiles
Reviewed Changes
Copilot reviewed 62 out of 62 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| e2e/cases/css/resolve-ts-paths/tsconfig.json | Removed baseUrl option |
| e2e/cases/css/inject-styles/tsconfig.json | Removed baseUrl option |
| e2e/cases/css/css-modules-dom/tsconfig.json | Removed baseUrl option |
| e2e/cases/cli/reload-env/tsconfig.json | Removed baseUrl option |
| e2e/cases/cli/reload-config/tsconfig.json | Removed baseUrl option |
| e2e/cases/cli/mode/tsconfig.json | Removed baseUrl option |
| e2e/cases/cli/falsy-plugins/tsconfig.json | Removed baseUrl option |
| e2e/cases/cli/build-watch/tsconfig.json | Removed baseUrl option |
| e2e/cases/cli/build-watch-restart/tsconfig.json | Removed baseUrl option |
| e2e/cases/cli/basic/tsconfig.json | Removed baseUrl option |
| e2e/cases/cli/base/tsconfig.json | Removed baseUrl option |
| e2e/cases/cache/cache-digest/tsconfig.json | Removed baseUrl option |
| e2e/cases/cache/build-dependencies/tsconfig.json | Removed baseUrl option |
| e2e/cases/babel/decorator/tsconfig.json | Removed baseUrl option |
| e2e/cases/alias/tsconfig-paths/tsconfig.json | Removed baseUrl option |
| e2e/cases/alias/tsconfig-paths-specify-config/tsconfig.json | Removed baseUrl option |
| e2e/cases/alias/tsconfig-paths-specify-config/tsconfig.custom.json | Removed baseUrl option |
| e2e/cases/alias/tsconfig-paths-reload/tsconfig.json | Removed baseUrl option |
| e2e/cases/alias/tsconfig-paths-references/tsconfig.app.json | Removed baseUrl option |
| e2e/cases/alias/jsconfig-paths/jsconfig.json | Removed baseUrl option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove baseUrl option from tsconfig, it's useless and will be removed in future.
Related Links
baseUrlis not respected microsoft/typescript-go#474 (comment)Checklist