Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

Remove unnecessary mocks from the test files to simplify the test setup and improve maintainability.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings June 5, 2025 04:54
@netlify
Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit e5f6a9e
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/684122ee44bc3f000894d536
😎 Deploy Preview https://deploy-preview-5363--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 45 (🔴 down 25 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the test setup by removing unnecessary mocks in the test files to improve maintainability.

  • Removed the vi.mock in html.test.ts
  • Removed the vi.mock in cache.test.ts

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/core/tests/html.test.ts Removed a vi.mock on '../src/helpers.js' to simplify tests
packages/core/tests/cache.test.ts Removed a vi.mock on '../src/helpers.js' to simplify tests

@chenjiahan chenjiahan merged commit 4b0dd60 into main Jun 5, 2025
12 checks passed
@chenjiahan chenjiahan deleted the remove_mock_0605 branch June 5, 2025 05:10
@chenjiahan chenjiahan mentioned this pull request Jun 6, 2025
@chenjiahan chenjiahan mentioned this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant