Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

Revised the description of Rsbuild's default compilation settings to clarify that JavaScript files outside the node_modules directory are compiled, and simplified the code snippet for the default value of source.include.

Removed the section explaining how to configure source.include for compiling monorepo libraries, which is no longer needed.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings June 2, 2025 14:04
@netlify
Copy link

netlify bot commented Jun 2, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 5ae5185
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/683daf5ee6b0eb0008a5eb54
😎 Deploy Preview https://deploy-preview-5345--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 47 (🔴 down 31 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the documentation for Rsbuild’s default source.include behavior—clarifying that JavaScript files outside node_modules are compiled—and removes outdated monorepo configuration examples.

  • Simplified the compilation scope descriptions in both English and Chinese guides
  • Streamlined the default source.include snippet to just two entries
  • Removed the monorepo-specific source.include configuration section

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
website/docs/zh/guide/advanced/browser-compatibility.mdx Updated compilation scope wording, removed numbering
website/docs/en/guide/advanced/browser-compatibility.mdx Updated compilation scope wording, removed numbering
website/docs/zh/config/source/include.mdx Simplified default include bullets, removed monorepo example
website/docs/en/config/source/include.mdx Simplified default include bullets, removed monorepo example
Comments suppressed due to low confidence (2)

website/docs/zh/config/source/include.mdx:11

  • 该条描述指出在任意目录下都编译 TS/JSX 文件,但默认示例中的 defaultInclude 首个条件 { not: /node_modules/ } 同样排除了 node_modules 目录。请将描述修改为“非 node_modules 目录下的 TypeScript 和 JSX 文件”以保持一致。
 - 任意目录下的 TypeScript 和 JSX 文件,匹配的文件后缀为 `.ts`、`.tsx`、`.jsx`、`.mts`、`.cts`。

website/docs/en/config/source/include.mdx:11

  • This bullet says TS/JSX are compiled in any directory, but the defaultInclude snippet’s { not: /node_modules/ } filter also excludes node_modules. Please update the text to “TypeScript and JSX files not in the node_modules directory” for consistency.
 - TypeScript and JSX files in any directory, matching file extensions `.ts`, `.tsx`, `.jsx`, `.mts`, `.cts`.

@chenjiahan chenjiahan merged commit da69061 into main Jun 4, 2025
12 checks passed
@chenjiahan chenjiahan deleted the compile_scope_doc_0602 branch June 4, 2025 03:37
@chenjiahan chenjiahan mentioned this pull request Jun 4, 2025
@chenjiahan chenjiahan mentioned this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant