Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

Reorganized sections to focus on "Compilation scope" instead of "Downgrade method," providing clearer explanations for Rsbuild's categorization and rationale.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings June 1, 2025 12:57
@netlify
Copy link

netlify bot commented Jun 1, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 2274c07
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/683c4e4d9fc65b0008e5a24d
😎 Deploy Preview https://deploy-preview-5341--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 73 (🔴 down 13 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines terminology around “降级”/“downgrade” to “编译范围”/“Compilation scope” and updates examples to illustrate the new object-based include filter syntax.

  • Renamed section headings and list labels for clarity in both Chinese and English docs.
  • Clarified default SWC transformation scope and rationale.
  • Replaced simplistic path.resolve examples with an advanced filter object to exclude node_modules.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
website/docs/zh/guide/advanced/browser-compatibility.mdx Updated headings, lists, and clarified default SWC scope; added filter example using { and: […], not: … }
website/docs/zh/config/source/include.mdx Adjusted heading terminology for monorepo modules
website/docs/en/guide/advanced/browser-compatibility.mdx Mirrored terminology and example updates in English
website/docs/en/config/source/include.mdx Updated heading and terminology for monorepo modules
Comments suppressed due to low confidence (4)

website/docs/en/guide/advanced/browser-compatibility.mdx:145

  • [nitpick] Lowercase make after the comma or split into two sentences for correct grammar: e.g., ..., and make Rsbuild perform extra compilation for this dependency.
When you find that a third-party dependency causes compatibility issues, you can add this dependency to Rsbuild's [source.include](/config/source/include) config, Make Rsbuild do extra compilation for this dependency.

website/docs/en/config/source/include.mdx:94

  • [nitpick] Heading uses “libraries” but the text refers to “modules”—consider using a single term (e.g., “modules”) for consistency.
## Compile libraries in monorepo

website/docs/zh/guide/advanced/browser-compatibility.mdx:178

  • Consider adding a brief note explaining this object-based include filter syntax (and with not) so readers understand how it excludes node_modules.
{ and: [packagesDir, { not: /[\\/]node_modules[\\/]/ }], }

website/docs/en/guide/advanced/browser-compatibility.mdx:178

  • Add a short explanation of the { and: […], not: … } filter syntax to help readers unfamiliar with this advanced include pattern.
{ and: [packagesDir, { not: /[\\/]node_modules[\\/]/ }], }

@chenjiahan chenjiahan merged commit cc088e7 into main Jun 1, 2025
12 checks passed
@chenjiahan chenjiahan deleted the compilation_scope_0601 branch June 1, 2025 13:46
@chenjiahan chenjiahan mentioned this pull request Jun 2, 2025
@chenjiahan chenjiahan mentioned this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant