docs: correct default buildDependencies#5222
Merged
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom May 12, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chenjiahan
approved these changes
May 12, 2025
Member
chenjiahan
left a comment
There was a problem hiding this comment.
LGTM 👍
When using JavaScript API, the default value depends on the parameters of createRsbuild(), I will add more description later.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
The
.envand.env.*files are included inbuildDependencieswithin thecreateRsbuildfunction. This setup allows these files to be utilized by frameworks built on top of Rsbuild, such as Rspeedy and Rslib.rsbuild/packages/core/src/createRsbuild.ts
Lines 140 to 150 in 045c4e4
In contrast, the
rsbuild.config.*files are added tobuildDependencieswithin theloadConfigfunction.rsbuild/packages/core/src/config.ts
Lines 449 to 452 in 045c4e4
However, this does not apply to Rspeedy, as it does not utilize the
loadConfigfunction from Rsbuild.It does work in Rslib and Rspress (using
rslib.config.*andrspress.config.*), so I'm uncertain if the current explanation forrsbuild.config.*is sufficiently clear.Related Links
See lynx-family/lynx-stack#766
Checklist