Skip to content

feat: support for specifying more browser names#4955

Merged
chenjiahan merged 1 commit intomainfrom
browser_name_0403
Apr 3, 2025
Merged

feat: support for specifying more browser names#4955
chenjiahan merged 1 commit intomainfrom
browser_name_0403

Conversation

@chenjiahan
Copy link
Member

Summary

This is a prerequisite for supporting #4879.

  1. When setting the process.env.BROWSER environment variable, Rsbuild now passes it to the app option of open to specify the browser name.
  2. Refactor the AppleScript related code to make it clearer.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Apr 3, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 20cab01
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67ee90aa4e8c4300087f3457
😎 Deploy Preview https://deploy-preview-4955--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 84 (🟢 up 10 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 419de0a into main Apr 3, 2025
12 checks passed
@chenjiahan chenjiahan deleted the browser_name_0403 branch April 3, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant