Skip to content

chore(types): simplify ProviderInstance type definition #4948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Apr 2, 2025
Merged

chore(types): simplify ProviderInstance type definition #4948

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions packages/core/src/types/rsbuild.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,20 +151,12 @@ export type StartDevServer = (
options?: StartDevServerOptions,
) => Promise<StartServerResult>;

export type ProviderInstance<B extends 'rspack' | 'webpack' = 'rspack'> = {
export type ProviderInstance<B extends 'rspack' | 'webpack' = 'rspack'> = Pick<
RsbuildInstance,
'build' | 'createCompiler' | 'createDevServer' | 'startDevServer'
> & {
readonly bundler: Bundler;

createCompiler: CreateCompiler;

/**
* It is designed for higher-level frameworks that require a custom server
*/
createDevServer: CreateDevServer;

startDevServer: StartDevServer;

build: Build;

initConfigs: () => Promise<
B extends 'rspack' ? Rspack.Configuration[] : WebpackConfig[]
>;
Expand Down
Loading