Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions e2e/cases/lazy-compilation/basic/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,50 @@ rspackOnlyTest(

const rsbuild = await dev({
cwd: __dirname,
rsbuildConfig: {
dev: {
lazyCompilation: true,
},
},
});

await gotoPage(page, rsbuild, 'page1');
await expect(page.locator('#test')).toHaveText('Page 1');
await expectPoll(() =>
rsbuild.logs.some((log) => log.includes('building src/page1/index.js')),
).toBeTruthy();
expect(
rsbuild.logs.some((log) => log.includes('building src/page2/index.js')),
).toBeFalsy();

await gotoPage(page, rsbuild, 'page2');
await expect(page.locator('#test')).toHaveText('Page 2');
await expectPoll(() =>
rsbuild.logs.some((log) => log.includes('building src/page2/index.js')),
).toBeTruthy();

await rsbuild.close();
},
);

rspackOnlyTest(
'should allow to configure `tools.rspack.experiments.lazyCompilation`',
async ({ page }) => {
if (process.platform === 'win32') {
test.skip();
}

const rsbuild = await dev({
cwd: __dirname,
rsbuildConfig: {
tools: {
rspack: {
experiments: {
lazyCompilation: true,
},
},
},
},
});

await gotoPage(page, rsbuild, 'page1');
Expand Down
3 changes: 0 additions & 3 deletions e2e/cases/lazy-compilation/basic/rsbuild.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,4 @@ export default defineConfig({
page2: './src/page2/index.js',
},
},
dev: {
lazyCompilation: true,
},
});
31 changes: 23 additions & 8 deletions packages/core/src/server/devMiddlewares.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { isAbsolute, join } from 'node:path';
import { rspack } from '@rspack/core';
import { normalizePublicDirs } from '../defaultConfig';
import { castArray, pick } from '../helpers';
import { castArray, isMultiCompiler, pick } from '../helpers';
import { logger } from '../logger';
import type {
DevConfig,
Expand Down Expand Up @@ -67,7 +67,6 @@ const applySetupMiddlewares = (
export type Middlewares = Array<RequestHandler | [string, RequestHandler]>;

const applyDefaultMiddlewares = async ({
dev,
devServerAPI,
middlewares,
server,
Expand Down Expand Up @@ -125,14 +124,30 @@ const applyDefaultMiddlewares = async ({
if (
context.action === 'dev' &&
context.bundlerType === 'rspack' &&
dev.lazyCompilation &&
compilationManager
) {
middlewares.push(
rspack.experiments.lazyCompilationMiddleware(
compilationManager.compiler,
) as RequestHandler,
);
const { compiler } = compilationManager;

// We check the compiler options to determine whether lazy compilation is enabled.
// Rsbuild users can enable lazy compilation in two ways:
// 1. Use Rsbuild's `dev.lazyCompilation` option
// 2. Use Rspack's `experiments.lazyCompilation` option
const isLazyCompilationEnabled = () => {
if (isMultiCompiler(compiler)) {
return compiler.compilers.some(
(childCompiler) => childCompiler.options.experiments?.lazyCompilation,
);
}
return compiler.options.experiments?.lazyCompilation;
};

if (isLazyCompilationEnabled()) {
middlewares.push(
rspack.experiments.lazyCompilationMiddleware(
compiler,
) as RequestHandler,
);
}
}

if (server.base && server.base !== '/') {
Expand Down
Loading