Skip to content

test(e2e): ensure proper async handling #4883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Mar 27, 2025
Merged

test(e2e): ensure proper async handling #4883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/cases/lazy-compilation/basic/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ rspackOnlyTest(
await gotoPage(page, rsbuild, 'page2');
await expect(page.locator('#test')).toHaveText('Page 2');

rsbuild.close();
await rsbuild.close();
},
);
4 changes: 2 additions & 2 deletions e2e/cases/module/glob-import/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ rspackOnlyTest(
await expect(page.locator('#header')).toHaveText('Header');
await expect(page.locator('#footer')).toHaveText('Footer');

rsbuild.close();
await rsbuild.close();
},
);

Expand All @@ -27,6 +27,6 @@ rspackOnlyTest(
await expect(page.locator('#header')).toHaveText('Header');
await expect(page.locator('#footer')).toHaveText('Footer');

rsbuild.close();
await rsbuild.close();
},
);
4 changes: 2 additions & 2 deletions e2e/cases/preact/basic/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ rspackOnlyTest(

const button = page.locator('#button');
await expect(button).toHaveText('count: 0');
button.click();
await button.click();
await expect(button).toHaveText('count: 1');

await rsbuild.close();
Expand All @@ -28,7 +28,7 @@ rspackOnlyTest(

const button = page.locator('#button');
await expect(button).toHaveText('count: 0');
button.click();
await button.click();
await expect(button).toHaveText('count: 1');

await rsbuild.close();
Expand Down
4 changes: 2 additions & 2 deletions e2e/cases/react/basic/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ rspackOnlyTest(

const button = page.locator('#button');
await expect(button).toHaveText('count: 0');
button.click();
await button.click();
await expect(button).toHaveText('count: 1');

await rsbuild.close();
Expand All @@ -28,7 +28,7 @@ rspackOnlyTest(

const button = page.locator('#button');
await expect(button).toHaveText('count: 0');
button.click();
await button.click();
await expect(button).toHaveText('count: 1');

await rsbuild.close();
Expand Down
4 changes: 2 additions & 2 deletions e2e/cases/react/react-compiler-babel/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ rspackOnlyTest(

const button = page.locator('#button');
await expect(button).toHaveText('count: 0');
button.click();
await button.click();
await expect(button).toHaveText('count: 1');

await rsbuild.close();
Expand All @@ -28,7 +28,7 @@ rspackOnlyTest(

const button = page.locator('#button');
await expect(button).toHaveText('count: 0');
button.click();
await button.click();
await expect(button).toHaveText('count: 1');

const index = await rsbuild.getIndexFile();
Expand Down
10 changes: 5 additions & 5 deletions e2e/cases/solid/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ rspackOnlyTest(
const button = page.locator('#button');
await expect(button).toHaveText('count: 0');

button.click();
await button.click();
await expect(button).toHaveText('count: 1');
rsbuild.close();
await rsbuild.close();
},
);

Expand All @@ -49,9 +49,9 @@ rspackOnlyTest(
const button = page.locator('#button');
await expect(button).toHaveText('count: 0');

button.click();
await button.click();
await expect(button).toHaveText('count: 1');
rsbuild.close();
await rsbuild.close();
},
);

Expand All @@ -70,7 +70,7 @@ for (const name of ['less', 'scss', 'stylus']) {
// use the text color to assert the compilation result
await expect(title).toHaveCSS('color', 'rgb(255, 62, 0)');

rsbuild.close();
await rsbuild.close();
},
);
}
2 changes: 1 addition & 1 deletion e2e/cases/svelte/hmr/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,5 @@ rspackOnlyTest('HMR should work properly', async ({ page }) => {
await expect(a).toHaveText('A: 0');

fs.writeFileSync(bPath, sourceCodeB, 'utf-8'); // recover the source code
rsbuild.close();
await rsbuild.close();
});
4 changes: 2 additions & 2 deletions e2e/cases/svelte/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ rspackOnlyTest(

await expect(title).toHaveText('Hello world!');

rsbuild.close();
await rsbuild.close();
},
);

Expand All @@ -53,7 +53,7 @@ for (const name of ['less', 'scss', 'stylus']) {
// use the text color to assert the compilation result
await expect(title).toHaveCSS('color', 'rgb(255, 62, 0)');

rsbuild.close();
await rsbuild.close();
},
);
}
2 changes: 1 addition & 1 deletion e2e/cases/svelte/ts/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ rspackOnlyTest(
const count = page.locator('#count');
await expect(count).toHaveText('Count: 2');

rsbuild.close();
await rsbuild.close();
},
);
Loading