Skip to content

fix(overlay): avoid multiple error overlay instances #4803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 2 commits into from
Mar 16, 2025
Merged

fix(overlay): avoid multiple error overlay instances #4803

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e6cc31
fix(overlay): avoid multiple error overlay instances
chenjiahan Mar 16, 2025
950747a
fix: type
chenjiahan Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/core/src/client/overlay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ class ErrorOverlay extends HTMLElement {
document.addEventListener('keydown', onEscKeydown);
}

close = () => {
close = (immediate: unknown = false) => {
const remove = () => this.parentNode?.removeChild(this);

if (this.animate) {
if (this.animate && immediate !== true) {
this.animate([{ opacity: 1 }, { opacity: 0 }], {
duration: 300,
easing: 'ease-out',
Expand All @@ -69,7 +69,10 @@ function createOverlay(html: string) {
function clearOverlay() {
// use NodeList's forEach api instead of dom.iterable
// biome-ignore lint/complexity/noForEach: <explanation>
document.querySelectorAll<ErrorOverlay>(overlayId).forEach((n) => n.close());
document
.querySelectorAll<ErrorOverlay>(overlayId)
// close overlay immediately to avoid multiple overlays at the same time
.forEach((n) => n.close(true));
}

if (typeof document !== 'undefined') {
Expand Down
Loading