Skip to content

fix: should merge copy config correctly when copy config type is different#4793

Merged
chenjiahan merged 4 commits intomainfrom
fix/merge-copy-config
Mar 14, 2025
Merged

fix: should merge copy config correctly when copy config type is different#4793
chenjiahan merged 4 commits intomainfrom
fix/merge-copy-config

Conversation

@9aoy
Copy link
Contributor

@9aoy 9aoy commented Mar 14, 2025

Summary

should merge copy config correctly when copy config type difference.

// config1 
output: {
  copy: {
    patterns: [
      {
        from: '../../../assets/icon.png',
      },
    ],
   },
},

// config2
output: {
  copy: [
    {
      from: '../../../assets/image.png',
    },
  ],
},

expect:

output: {
  copy: {
    patterns: [
      {
        from: '../../../assets/icon.png',
      },
      {
        from: '../../../assets/image.png',
      },
    ],
  },
},

actual:

output: {
  copy: [
    {
      patterns: [
        {
          from: '../../../assets/icon.png',
        },
      ],
    },
    {
      from: '../../../assets/image.png',
    },
  ],
 }

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Mar 14, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit a4b5ac1
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67d42f2d4fc776000810cb34
😎 Deploy Preview https://deploy-preview-4793--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 74 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan changed the title fix: should merge copy config correctly when copy config type difference fix: should merge copy config correctly when copy config type is different Mar 14, 2025
@chenjiahan chenjiahan enabled auto-merge (squash) March 14, 2025 13:29
@chenjiahan chenjiahan merged commit e0c8b79 into main Mar 14, 2025
10 checks passed
@chenjiahan chenjiahan deleted the fix/merge-copy-config branch March 14, 2025 13:36
@chenjiahan chenjiahan mentioned this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants