Skip to content

fix: failed to use native config loader on Windows #4512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Feb 9, 2025
Merged

fix: failed to use native config loader on Windows #4512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions e2e/cases/cli/config-loader/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,9 @@
import { execSync } from 'node:child_process';
import path from 'node:path';
import { globContentJSON, rspackOnlyTest } from '@e2e/helper';
import { expect, test } from '@playwright/test';
import { expect } from '@playwright/test';

rspackOnlyTest('should use Node.js native loader to load config', async () => {
// TODO: fix this test on Windows
if (process.platform === 'win32') {
test.skip();
}

execSync('npx rsbuild build --config-loader native', {
cwd: __dirname,
env: {
Expand Down
4 changes: 3 additions & 1 deletion packages/core/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import fs from 'node:fs';
import { createRequire } from 'node:module';
import { dirname, isAbsolute, join } from 'node:path';
import { pathToFileURL } from 'node:url';
import type { ChokidarOptions } from '../compiled/chokidar/index.js';
import RspackChain from '../compiled/rspack-chain/index.js';
import {
Expand Down Expand Up @@ -472,7 +473,8 @@ export async function loadConfig({

if (loader === 'native' || /\.(?:js|mjs|cjs)$/.test(configFilePath)) {
try {
const exportModule = await import(`${configFilePath}?t=${Date.now()}`);
const configFileURL = pathToFileURL(configFilePath).href;
const exportModule = await import(`${configFileURL}?t=${Date.now()}`);
configExport = exportModule.default ? exportModule.default : exportModule;
} catch (err) {
if (loader === 'native') {
Expand Down