Skip to content

fix: validate server.base config #4493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Feb 7, 2025
Merged

fix: validate server.base config #4493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ export async function loadConfig({

let configExport: RsbuildConfigExport;

if (/\.(?:js|mjs|cjs)$/.test(configFilePath) || loader === 'native') {
if (loader === 'native' || /\.(?:js|mjs|cjs)$/.test(configFilePath)) {
try {
const exportModule = await import(`${configFilePath}?t=${Date.now()}`);
configExport = exportModule.default ? exportModule.default : exportModule;
Expand Down
9 changes: 9 additions & 0 deletions packages/core/src/provider/initConfigs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,14 @@ const initEnvironmentConfigs = (
};
};

const validateRsbuildConfig = (config: NormalizedConfig) => {
if (config.server.base && !config.server.base.startsWith('/')) {
throw new Error(
`[rsbuild:config] The "server.base" option should start with a slash, for example: "/base"`,
);
}
};

export async function initRsbuildConfig({
context,
pluginManager,
Expand Down Expand Up @@ -215,6 +223,7 @@ export async function initRsbuildConfig({

await updateEnvironmentContext(context, environments);
updateContextByNormalizedConfig(context);
validateRsbuildConfig(context.normalizedConfig);

return context.normalizedConfig;
}
Expand Down