Skip to content

test: split assets retry cases #4430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 2 commits into from
Jan 24, 2025
Merged

test: split assets retry cases #4430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11d0ee9
test: split assets retry cases
9aoy Jan 24, 2025
0126a5e
fix: lint
9aoy Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
205 changes: 205 additions & 0 deletions e2e/cases/assets/assets-retry/addQuery.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,205 @@
import { gotoPage, proxyConsole } from '@e2e/helper';
import { expect, test } from '@playwright/test';
import { logger } from '@rsbuild/core';
import {
count404ResponseByUrl,
createBlockMiddleware,
createRsbuildWithMiddleware,
} from './helper';

test('should work with addQuery boolean option', async ({ page }) => {
logger.level = 'verbose';
const { logs, restore } = proxyConsole();
const initialChunkBlockedMiddleware = createBlockMiddleware({
blockNum: 3,
urlPrefix: '/static/js/index.js',
});

const asyncChunkBlockedMiddleware = createBlockMiddleware({
blockNum: 3,
urlPrefix: '/static/js/async/src_AsyncCompTest_tsx.js',
});
const rsbuild = await createRsbuildWithMiddleware(
[initialChunkBlockedMiddleware, asyncChunkBlockedMiddleware],
{
minify: true,
addQuery: true,
},
);

await gotoPage(page, rsbuild);
const compTestElement = page.locator('#comp-test');
await expect(compTestElement).toHaveText('Hello CompTest');

const asyncCompTestElement = page.locator('#async-comp-test');
await expect(asyncCompTestElement).toHaveText('Hello AsyncCompTest');

const blockedResponseCount = count404ResponseByUrl(
logs,
'/static/js/index.js',
);
expect(blockedResponseCount).toMatchObject({
'/static/js/index.js': 1,
'/static/js/index.js?retry=1': 1,
'/static/js/index.js?retry=2': 1,
});
const blockedAsyncChunkResponseCount = count404ResponseByUrl(
logs,
'/static/js/async/src_AsyncCompTest_tsx.js',
);
expect(blockedAsyncChunkResponseCount).toMatchObject({
'/static/js/async/src_AsyncCompTest_tsx.js': 1,
'/static/js/async/src_AsyncCompTest_tsx.js?retry=1': 1,
'/static/js/async/src_AsyncCompTest_tsx.js?retry=2': 1,
});

await rsbuild.close();
restore();
logger.level = 'log';
});

test('should work with addQuery boolean option when retrying async css chunk', async ({
page,
}) => {
logger.level = 'verbose';
const { logs, restore } = proxyConsole();

const asyncChunkBlockedMiddleware = createBlockMiddleware({
blockNum: 3,
urlPrefix: '/static/css/async/src_AsyncCompTest_tsx.css',
});
const rsbuild = await createRsbuildWithMiddleware(
asyncChunkBlockedMiddleware,
{
minify: true,
addQuery: true,
},
);

await gotoPage(page, rsbuild);
const asyncCompTestElement = page.locator('#async-comp-test');
await expect(asyncCompTestElement).toHaveText('Hello AsyncCompTest');
await expect(asyncCompTestElement).toHaveCSS(
'background-color',
'rgb(0, 0, 139)',
);

const blockedAsyncChunkResponseCount = count404ResponseByUrl(
logs,
'/static/css/async/src_AsyncCompTest_tsx.css',
);
expect(blockedAsyncChunkResponseCount).toMatchObject({
'/static/css/async/src_AsyncCompTest_tsx.css': 1,
'/static/css/async/src_AsyncCompTest_tsx.css?retry=1': 1,
'/static/css/async/src_AsyncCompTest_tsx.css?retry=2': 1,
});

await rsbuild.close();
restore();
logger.level = 'log';
});

test('should work with addQuery function type option', async ({ page }) => {
logger.level = 'verbose';
const { logs, restore } = proxyConsole();
const initialChunkBlockedMiddleware = createBlockMiddleware({
blockNum: 3,
urlPrefix: '/static/js/index.js',
});

const asyncChunkBlockedMiddleware = createBlockMiddleware({
blockNum: 3,
urlPrefix: '/static/js/async/src_AsyncCompTest_tsx.js',
});
const rsbuild = await createRsbuildWithMiddleware(
[initialChunkBlockedMiddleware, asyncChunkBlockedMiddleware],
{
minify: true,
addQuery: ({ times, originalQuery }) => {
const query =
times === 3 ? `retryCount=${times}&isLast=1` : `retryCount=${times}`;
return originalQuery ? `${originalQuery}&${query}` : `?${query}`;
},
},
);

await gotoPage(page, rsbuild);
const compTestElement = page.locator('#comp-test');
await expect(compTestElement).toHaveText('Hello CompTest');

const asyncCompTestElement = page.locator('#async-comp-test');
await expect(asyncCompTestElement).toHaveText('Hello AsyncCompTest');

const blockedResponseCount = count404ResponseByUrl(
logs,
'/static/js/index.js',
);
expect(blockedResponseCount).toMatchObject({
'/static/js/index.js': 1,
'/static/js/index.js?retryCount=1': 1,
'/static/js/index.js?retryCount=2': 1,
});
const blockedAsyncChunkResponseCount = count404ResponseByUrl(
logs,
'/static/js/async/src_AsyncCompTest_tsx.js',
);
expect(blockedAsyncChunkResponseCount).toMatchObject({
'/static/js/async/src_AsyncCompTest_tsx.js': 1,
'/static/js/async/src_AsyncCompTest_tsx.js?retryCount=1': 1,
'/static/js/async/src_AsyncCompTest_tsx.js?retryCount=2': 1,
});

await rsbuild.close();
restore();
logger.level = 'log';
});

test('should preserve users query when set addQuery option', async ({
page,
}) => {
logger.level = 'verbose';
const { logs, restore } = proxyConsole();

const blockedMiddleware1 = createBlockMiddleware({
blockNum: 3,
urlPrefix: '/test-query?a=1&b=1',
});
const blockedMiddleware2 = createBlockMiddleware({
blockNum: 3,
urlPrefix: '/test-query-hash?a=1&b=1',
});

const rsbuild = await createRsbuildWithMiddleware(
[blockedMiddleware1, blockedMiddleware2],
{
addQuery: true,
minify: true,
},
'./src/testQueryEntry.js',
);

await gotoPage(page, rsbuild);
const blockedResponseCount1 = count404ResponseByUrl(
logs,
'/test-query?a=1&b=1',
);
expect(blockedResponseCount1).toMatchObject({
'/test-query?a=1&b=1': 1,
'/test-query?a=1&b=1&retry=1': 1,
'/test-query?a=1&b=1&retry=2': 1,
});

const blockedResponseCount2 = count404ResponseByUrl(
logs,
'/test-query-hash?a=1&b=1',
);
expect(blockedResponseCount2).toMatchObject({
'/test-query-hash?a=1&b=1': 1,
'/test-query-hash?a=1&b=1&retry=1': 1,
'/test-query-hash?a=1&b=1&retry=2': 1,
});

await rsbuild.close();
restore();
logger.level = 'log';
});
79 changes: 79 additions & 0 deletions e2e/cases/assets/assets-retry/async.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
import { gotoPage, proxyConsole } from '@e2e/helper';
import { expect, test } from '@playwright/test';
import { logger } from '@rsbuild/core';
import {
count404Response,
createBlockMiddleware,
createRsbuildWithMiddleware,
} from './helper';

test('should work when blocking async chunk', async ({ page }) => {
logger.level = 'verbose';
const { logs, restore } = proxyConsole();
const blockedMiddleware = createBlockMiddleware({
blockNum: 3,
urlPrefix: '/static/js/async/src_AsyncCompTest_tsx.js',
});
const rsbuild = await createRsbuildWithMiddleware(blockedMiddleware, {});

await gotoPage(page, rsbuild);
const compTestElement = page.locator('#async-comp-test');
await expect(compTestElement).toHaveText('Hello AsyncCompTest');
const blockedResponseCount = count404Response(
logs,
'/static/js/async/src_AsyncCompTest_tsx.js',
);
expect(blockedResponseCount).toBe(3);
await rsbuild.close();
restore();
logger.level = 'log';
});

test('should work when blocking async css chunk`', async ({ page }) => {
logger.level = 'verbose';
const { logs, restore } = proxyConsole();
const blockedMiddleware = createBlockMiddleware({
blockNum: 3,
urlPrefix: '/static/css/async/src_AsyncCompTest_tsx.css',
});
const rsbuild = await createRsbuildWithMiddleware(blockedMiddleware, {});

await gotoPage(page, rsbuild);
const compTestElement = page.locator('#async-comp-test');
await expect(compTestElement).toHaveText('Hello AsyncCompTest');
await expect(compTestElement).toHaveCSS('background-color', 'rgb(0, 0, 139)');
const blockedResponseCount = count404Response(
logs,
'/static/css/async/src_AsyncCompTest_tsx.css',
);
expect(blockedResponseCount).toBe(3);
await rsbuild.close();
restore();
logger.level = 'log';
});

test('should work with minified runtime code when blocking async chunk', async ({
page,
}) => {
logger.level = 'verbose';
const { logs, restore } = proxyConsole();
const blockedMiddleware = createBlockMiddleware({
blockNum: 3,
urlPrefix: '/static/js/async/src_AsyncCompTest_tsx.js',
});
const rsbuild = await createRsbuildWithMiddleware(blockedMiddleware, {
minify: true,
});

await gotoPage(page, rsbuild);
const compTestElement = page.locator('#async-comp-test');
await expect(compTestElement).toHaveText('Hello AsyncCompTest');
const blockedResponseCount = count404Response(
logs,
'/static/js/async/src_AsyncCompTest_tsx.js',
);
expect(blockedResponseCount).toBe(3);
await rsbuild.close();
restore();
logger.level = 'log';
});
Loading
Loading