Skip to content

test: fix occasional directory not empty error in e2e #4428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 3 commits into from
Jan 24, 2025
Merged

test: fix occasional directory not empty error in e2e #4428

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dac2aec
test: fix occasional directory not empty error in e2e
9aoy Jan 24, 2025
4f282f2
Update e2e/cases/cli/watch-files/index.test.ts
9aoy Jan 24, 2025
f958b10
Update e2e/cases/cli/watch-files/index.test.ts
9aoy Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions e2e/cases/cli/watch-files/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { awaitFileExists, getRandomPort, rspackOnlyTest } from '@e2e/helper';
import { expect, test } from '@playwright/test';

const dist = path.join(__dirname, 'dist');
const distIndexFile = path.join(__dirname, 'dist/static/js/index.js');
const tempConfigPath = './test-temp-config.ts';
const tempOutputFile = path.join(__dirname, 'test-temp-file.txt');
const extraConfigFile = path.join(__dirname, tempConfigPath);
Expand All @@ -29,7 +30,7 @@ rspackOnlyTest(
});

// the first build
await awaitFileExists(dist);
await awaitFileExists(distIndexFile);

fs.rmSync(tempOutputFile, { force: true });
// temp config changed and trigger rebuild
Expand All @@ -55,9 +56,9 @@ rspackOnlyTest(
},
});

await awaitFileExists(dist);
await awaitFileExists(distIndexFile);

fs.rmSync(dist, { recursive: true });
fs.rmSync(distIndexFile);
// temp config changed
fs.writeFileSync(extraConfigFile, 'export default 2;');

Expand All @@ -79,9 +80,11 @@ rspackOnlyTest(
},
});

await awaitFileExists(dist);
// Fix occasional 'directory not empty' error when wait and rm dist.
// Sometimes the dist directory exists, but the files in the dist directory have not been completely written.
await awaitFileExists(distIndexFile);

fs.rmSync(dist, { recursive: true });
fs.rmSync(distIndexFile);
// temp config changed
fs.writeFileSync(extraConfigFile, 'export default 2;');

Expand Down
Loading