Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(loadConfig): allow to pass a meta data #4013

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

hasnum-stack
Copy link
Contributor

@hasnum-stack hasnum-stack commented Nov 19, 2024

Summary

Allow to pass a meta data to defineConfig function:

await loadConfig({
  meta: {},
});

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 2880a4a
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/673c6e50e14b6b0008f3dea5
😎 Deploy Preview https://deploy-preview-4013--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 82 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2024

CLA assistant check
All committers have signed the CLA.

@chenjiahan chenjiahan changed the title feat(loadConfig): loadConfig添加params参数,传递到config函数中 feat(loadConfig): allow to pass a meta data Nov 19, 2024
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have renamed this param to meta to be more semantically.

@chenjiahan
Copy link
Member

Hi, can you sign the CLA so we can merge this PR

@hasnum-stack
Copy link
Contributor Author

Hi, can you sign the CLA so we can merge this PR

👌🏻

@chenjiahan chenjiahan merged commit 7937a2c into web-infra-dev:main Nov 20, 2024
11 checks passed
@9aoy 9aoy mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants