Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add timeout for e2e and unit tests #3326

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

Jayllyz
Copy link
Contributor

@Jayllyz Jayllyz commented Aug 30, 2024

Summary

I noticed that some e2e workflows were stuck for hours :
https://github.com/web-infra-dev/rsbuild/actions/runs/10630679833?pr=3325

This PR adds a timeout for unit and e2e tests.
Feel free to adjust the timeout if it's too high or too low.

Related Links

gha doc: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 6ae6f4c
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66d1c42d46277200080f1a57
😎 Deploy Preview https://deploy-preview-3326--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 84 (🟢 up 10 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We are still investigating the cause of the CI timeout, which may be related to https://github.com/web-infra-dev/rsbuild/tree/main/e2e/cases/module-federation-v2.

@chenjiahan chenjiahan changed the title fix(ci): add timeout for e2e and unit tests chore(ci): add timeout for e2e and unit tests Aug 30, 2024
@chenjiahan chenjiahan enabled auto-merge (squash) August 30, 2024 13:44
@chenjiahan chenjiahan merged commit afc6fd5 into web-infra-dev:main Aug 30, 2024
11 checks passed
@Jayllyz Jayllyz deleted the fix/timeout-e2e-test branch August 30, 2024 13:53
@chenjiahan chenjiahan mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants