Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: change default charset to utf8 #3250

Merged
merged 2 commits into from
Aug 20, 2024
Merged

feat!: change default charset to utf8 #3250

merged 2 commits into from
Aug 20, 2024

Conversation

chenjiahan
Copy link
Member

Summary

Cange default charset from ascii to utf8.

Motivation:

  • Smaller output, no need to escape.
  • Align with the default value of SWC / Rspack / Vite.
  • Align with the default <meta charset="utf-8"> HTML meta tag.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 6f20bc9
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66c41269ada4250008122aee
😎 Deploy Preview https://deploy-preview-3250--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 73 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit b686c7d into main Aug 20, 2024
10 checks passed
@chenjiahan chenjiahan deleted the default_charset_0820 branch August 20, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants