Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rspack plugin apply error after merging config #2877

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

9aoy
Copy link
Contributor

@9aoy 9aoy commented Jul 11, 2024

Summary

fix rspack plugin apply error, only deep merge plain object when mergeConfig.

image

Related Links

https://www.npmjs.com/package/deepmerge#ismergeableobject

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 0537e04
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/668f7f131cf37b00088edef6
😎 Deploy Preview https://deploy-preview-2877--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 80 (🔴 down 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan changed the title fix: rspack plugin apply error fix: rspack plugin apply error after merging config Jul 11, 2024
@chenjiahan chenjiahan merged commit c4d6248 into main Jul 11, 2024
12 checks passed
@chenjiahan chenjiahan deleted the fix/rspack-plugin-apply-error branch July 11, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants