Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: allow passing user config to mergeEnvironmentConfig #2863

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

9aoy
Copy link
Contributor

@9aoy 9aoy commented Jul 10, 2024

Summary

update mergeEnvironmentConfig type, support use userConfig override extraConfig fields.

const myPlugin = () => ({
  setup: (api) => {
    api.modifyEnvironmentConfig((userConfig, { mergeEnvironmentConfig }) => {
      const extraConfig: EnvironmentConfig = {
        source: {
          // ...
        },
        output: {
          // ...
        },
      };

      return mergeEnvironmentConfig(extraConfig, userConfig);
    });
  },
});

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 9e3eff4
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/668e2e3a3d695b000862568c
😎 Deploy Preview https://deploy-preview-2863--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 86 (🔴 down 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan changed the title feat(types): support use userConfig override extraConfig fields in mergeEnvironmentConfig feat(types): support passing user config to mergeEnvironmentConfig Jul 10, 2024
@chenjiahan chenjiahan changed the title feat(types): support passing user config to mergeEnvironmentConfig types: allow passing user config to mergeEnvironmentConfig Jul 10, 2024
@chenjiahan chenjiahan merged commit b32983f into main Jul 10, 2024
12 checks passed
@chenjiahan chenjiahan deleted the type/mergeEnvironmentConfig branch July 10, 2024 07:01
@9aoy 9aoy mentioned this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants