Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: print and serve multiple environments html route correctly #2713

Merged
merged 6 commits into from
Jun 27, 2024

Conversation

9aoy
Copy link
Contributor

@9aoy 9aoy commented Jun 27, 2024

Summary

print and serve multiple environments html route correctly in basic case.

When we need to serve multiple environment products, rsbuild server can run correctly in the following case:

export default defineConfig({
  plugins: [pluginReact()],
  environments: {
    web: {},
    web1: {
      dev: {
        // assetPrefix is necessary when generating multiple environment web products, file search conflicts will occur if assetPrefix is ​​not added.
        assetPrefix: 'auto',
      },
      source: {
        entry: {
          main: './src/web1.tsx',
        },
      },
      output: {
        distPath: {
          root: 'dist/web1',
        },
      },
    },
  },
});

At this point, the print url is as follows:

  - index    http://localhost:3000/
  - main     http://localhost:3000/web1/main

Warning: not support serve multiply environments when distPath is different (non-inclusive relationship), such as, distPath.root: 'dist' in environment web and distPath.root: 'dist1' in environment web1

Related Links

#2620

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 1151b60
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/667d172bf3927f0008a50bf8
😎 Deploy Preview https://deploy-preview-2713--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 77 (🔴 down 11 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

packages/core/src/server/helper.ts Outdated Show resolved Hide resolved
packages/core/src/server/helper.ts Outdated Show resolved Hide resolved
packages/core/src/server/helper.ts Outdated Show resolved Hide resolved
@9aoy 9aoy requested a review from chenjiahan June 27, 2024 08:00
@chenjiahan chenjiahan merged commit d060c6a into web-infra-dev:main Jun 27, 2024
10 checks passed
@9aoy 9aoy mentioned this pull request Jun 27, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants