Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .changeset/young-coins-bet.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
'@modern-js/plugin-router-v5': patch
'@modern-js/plugin-router-v7': patch
'@modern-js/plugin-garfish': patch
'@modern-js/runtime': patch
'@modern-js/plugin-testing': patch
'@modern-js/plugin-express': patch
'@modern-js/plugin-state': patch
'@modern-js/app-tools': patch
'@modern-js/plugin-koa': patch
'@modern-js/uni-builder': patch
---

feat: support resolve configuration in rsbuild.
feat: 支持 rsbuild 的 resolve 配置。
11 changes: 9 additions & 2 deletions packages/cli/plugin-bff/src/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,13 @@ import type { AppTools, CliPlugin } from '@modern-js/app-tools';
import { ApiRouter } from '@modern-js/bff-core';
import { compile } from '@modern-js/server-utils';
import type { ServerRoute } from '@modern-js/types';
import { fs, API_DIR, SHARED_DIR, normalizeOutputPath } from '@modern-js/utils';
import {
fs,
API_DIR,
type AliasOption,
SHARED_DIR,
normalizeOutputPath,
} from '@modern-js/utils';
import clientGenerator from './utils/clientGenerator';
import pluginGenerator from './utils/pluginGenerator';
import runtimeGenerator from './utils/runtimeGenerator';
Expand Down Expand Up @@ -43,14 +49,15 @@ export const bffPlugin = (): CliPlugin<AppTools> => ({

const { server } = modernConfig;
const { alias } = modernConfig.source;
const { alias: resolveAlias } = modernConfig.resolve;
const { babel } = modernConfig.tools;

if (sourceDirs.length > 0) {
await compile(
appDirectory,
{
server,
alias,
alias: { ...alias, ...(resolveAlias as AliasOption) },
babelConfig: babel,
},
{
Expand Down
10 changes: 10 additions & 0 deletions packages/cli/uni-builder/src/shared/parseCommonConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ export async function parseCommonConfig(
...toolsConfig
} = {},
environments = {},
resolve = {},
} = uniBuilderConfig;

const rsbuildConfig: RsbuildConfig = {
Expand All @@ -146,6 +147,7 @@ export async function parseCommonConfig(
sourceMap,
...outputConfig,
},
resolve,
source: {
alias: alias as unknown as SourceConfig['alias'],
...sourceConfig,
Expand All @@ -157,6 +159,14 @@ export async function parseCommonConfig(
environments,
};

/**
* 在老版本中,默认 source.alias 为空对象。Rsbuild 新版本推荐使用 resolve.alias 代替 source.alias
* 因此如果 alias 为空对象,则删除 source.alias,避免在默认情况下出现警告
*/
if (typeof alias === 'object' && Object.keys(alias).length === 0) {
delete rsbuildConfig.source?.alias;
}

rsbuildConfig.tools!.htmlPlugin = htmlPlugin as ToolsConfig['htmlPlugin'];

rsbuildConfig.tools!.lightningcssLoader ??= false;
Expand Down
1 change: 1 addition & 0 deletions packages/cli/uni-builder/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,7 @@ export type UniBuilderConfig = {
performance?: RsbuildConfig['performance'];
security?: Omit<SecurityConfig, 'sri'>;
tools?: Omit<ToolsConfig, 'htmlPlugin'>;
resolve?: RsbuildConfig['resolve'];
source?: Omit<SourceConfig, 'alias' | 'transformImport'>;
// plugins is a new field, should avoid adding modern plugin by mistake
plugins?: RsbuildPlugins;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ exports[`parseCommonConfig > dev.xxx 1`] = `
},
"performance": {},
"plugins": [],
"resolve": {},
"security": {},
"server": {
"compress": false,
Expand Down Expand Up @@ -94,6 +95,7 @@ exports[`parseCommonConfig > dev.xxx 2`] = `
},
"performance": {},
"plugins": [],
"resolve": {},
"security": {},
"server": {
"htmlFallback": false,
Expand Down Expand Up @@ -147,6 +149,7 @@ exports[`parseCommonConfig > html.faviconByEntries 1`] = `
},
"performance": {},
"plugins": [],
"resolve": {},
"security": {},
"server": {
"htmlFallback": false,
Expand Down Expand Up @@ -202,6 +205,7 @@ exports[`parseCommonConfig > html.faviconByEntries 2`] = `
},
"performance": {},
"plugins": [],
"resolve": {},
"security": {},
"server": {
"htmlFallback": false,
Expand Down Expand Up @@ -260,6 +264,7 @@ exports[`parseCommonConfig > html.faviconByEntries 3`] = `
},
"performance": {},
"plugins": [],
"resolve": {},
"security": {},
"server": {
"htmlFallback": false,
Expand Down Expand Up @@ -315,6 +320,7 @@ exports[`parseCommonConfig > html.metaByEntries 1`] = `
},
"performance": {},
"plugins": [],
"resolve": {},
"security": {},
"server": {
"htmlFallback": false,
Expand Down Expand Up @@ -377,6 +383,7 @@ exports[`parseCommonConfig > html.metaByEntries 2`] = `
},
"performance": {},
"plugins": [],
"resolve": {},
"security": {},
"server": {
"htmlFallback": false,
Expand Down Expand Up @@ -432,6 +439,7 @@ exports[`parseCommonConfig > html.templateByEntries 1`] = `
},
"performance": {},
"plugins": [],
"resolve": {},
"security": {},
"server": {
"htmlFallback": false,
Expand Down Expand Up @@ -490,6 +498,7 @@ exports[`parseCommonConfig > html.templateByEntries 2`] = `
},
"performance": {},
"plugins": [],
"resolve": {},
"security": {},
"server": {
"htmlFallback": false,
Expand Down Expand Up @@ -545,6 +554,7 @@ exports[`parseCommonConfig > html.templateParametersByEntries 1`] = `
},
"performance": {},
"plugins": [],
"resolve": {},
"security": {},
"server": {
"htmlFallback": false,
Expand Down Expand Up @@ -605,6 +615,7 @@ exports[`parseCommonConfig > html.templateParametersByEntries 2`] = `
},
"performance": {},
"plugins": [],
"resolve": {},
"security": {},
"server": {
"htmlFallback": false,
Expand Down Expand Up @@ -662,6 +673,7 @@ exports[`parseCommonConfig > html.titleByEntries 1`] = `
},
"performance": {},
"plugins": [],
"resolve": {},
"security": {},
"server": {
"htmlFallback": false,
Expand Down Expand Up @@ -719,6 +731,7 @@ exports[`parseCommonConfig > html.titleByEntries 2`] = `
},
"performance": {},
"plugins": [],
"resolve": {},
"security": {},
"server": {
"htmlFallback": false,
Expand Down Expand Up @@ -776,6 +789,7 @@ exports[`parseCommonConfig > output.cssModuleLocalIdentName 1`] = `
},
"performance": {},
"plugins": [],
"resolve": {},
"security": {},
"server": {
"htmlFallback": false,
Expand Down Expand Up @@ -833,6 +847,7 @@ exports[`parseCommonConfig > output.disableCssModuleExtension 1`] = `
},
"performance": {},
"plugins": [],
"resolve": {},
"security": {},
"server": {
"htmlFallback": false,
Expand Down Expand Up @@ -886,6 +901,7 @@ exports[`parseCommonConfig > output.enableInlineScripts 1`] = `
},
"performance": {},
"plugins": [],
"resolve": {},
"security": {},
"server": {
"htmlFallback": false,
Expand Down Expand Up @@ -937,6 +953,7 @@ exports[`parseCommonConfig > output.enableInlineStyles 1`] = `
},
"performance": {},
"plugins": [],
"resolve": {},
"security": {},
"server": {
"htmlFallback": false,
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime/plugin-garfish/src/cli/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ export const garfishPlugin = (): CliPluginFuture<AppTools<'shared'>> => ({
output: {
disableCssExtract,
},
source: {
resolve: {
alias: {
[`@${metaName}/runtime/garfish`]: `@${metaName}/plugin-garfish/runtime`,
},
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime/plugin-router-v5/src/cli/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export const routerPlugin = (): CliPluginFuture<AppTools> => ({
);

return {
source: {
resolve: {
alias: {
[`@${metaName}/runtime/router-v5`]: routerExportsUtils.getPath(),
},
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime/plugin-router-v5/tests/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ describe('cli-router-legacy', () => {
const config = await api.getHooks().config.call();
expect(
config.find(
(item: any) => item.source.alias['@modern-js/runtime/plugins'],
(item: any) => item.resolve.alias['@modern-js/runtime/plugins'],
),
).toBeTruthy();
});
Expand Down
4 changes: 3 additions & 1 deletion packages/runtime/plugin-router-v7/src/cli/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const routerPlugin = (): CliPluginFuture<AppTools> => ({
});
}
return {
source: {
resolve: {
alias: {
'react-router-dom$': require
.resolve('../runtime')
Expand All @@ -30,6 +30,8 @@ export const routerPlugin = (): CliPluginFuture<AppTools> => ({
.resolve('../runtime')
.replace(/\/cjs\//, '/esm/'),
},
},
source: {
globalVars: {
'process.env._MODERN_ROUTER_VERSION': 'v7',
},
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime/plugin-runtime/src/cli/alias.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const builderPluginAlias = ({
}
});
return mergeRsbuildConfig(userConfig, {
source: {
resolve: {
alias: { ...entrypointsAlias, ...mainEntrypointsAlias },
},
});
Expand Down
4 changes: 3 additions & 1 deletion packages/runtime/plugin-runtime/src/cli/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export const runtimePlugin = (params?: {
return {
runtime: {},
runtimeByEntries: {},
source: {
resolve: {
alias: {
/**
* twin.macro inserts styled-components into the code during the compilation process
Expand All @@ -112,6 +112,8 @@ export const runtimePlugin = (params?: {
),
'@meta/runtime$': require.resolve('@modern-js/runtime'),
},
},
source: {
globalVars: {
'process.env.IS_REACT18': process.env.IS_REACT18,
},
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime/plugin-runtime/src/cli/ssr/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ export const ssrPlugin = (): CliPluginFuture<AppTools<'shared'>> => ({

return {
builderPlugins: [ssrBuilderPlugin(api)],
source: {
resolve: {
alias: {
// ensure that all packages use the same storage in @modern-js/runtime-utils/node
'@modern-js/runtime-utils/node$': require
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime/plugin-runtime/tests/router/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ describe('cli-router', () => {
const config = await runner.config();
expect(
config.find(
(item: any) => item.source.alias['@modern-js/runtime/plugins'],
(item: any) => item.resolve.alias['@modern-js/runtime/plugins'],
),
).toBeTruthy();
});
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime/plugin-state/src/cli/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export const statePlugin = (): CliPluginFuture<AppTools<'shared'>> => ({
api.config(() => {
const { metaName } = api.getAppContext();
return {
source: {
resolve: {
alias: {
[`@${metaName}/runtime/model`]: `@${metaName}/plugin-state/runtime`,
},
Expand Down
3 changes: 3 additions & 0 deletions packages/runtime/plugin-testing/src/base/config/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ export type UserConfig = {
source?: {
alias?: AliasOption;
};
resolve?: {
alias?: AliasOption;
};
testing?: TestConfig;
tools?: {
jest: JestConfig | ((config: JestConfig) => JestConfig);
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime/plugin-testing/src/cli/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export const testingPlugin = (): CliPlugin<{
);

return {
source: {
resolve: {
alias: {
// The module-tools alias configuration is different and more specific than app-tools.
// So for the time being, the @ alias is configured here.
Expand Down
2 changes: 1 addition & 1 deletion packages/server/plugin-express/src/cli/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export const expressPlugin = (): CliPlugin<AppTools> => ({
: '@modern-js/plugin-express/runtime';

return {
source: {
resolve: {
alias: {
'@modern-js/runtime/server': runtimePath,
'@modern-js/runtime/express': runtimePath,
Expand Down
2 changes: 1 addition & 1 deletion packages/server/plugin-koa/src/cli/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export const koaPlugin = (): CliPlugin<AppTools> => ({
'@modern-js/runtime/koa': runtimePath,
},
},
source: {
resolve: {
alias: {
'@modern-js/runtime/server$': alias,
'@modern-js/runtime/koa': alias,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ export function createBuilderProviderConfig<B extends Bundler>(
const config = {
...resolveConfig,
plugins: [],
resolve: {
...resolveConfig.resolve,
},
dev: {
...resolveConfig.dev,
port: appContext.port,
Expand Down
Loading