Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the updated envs value is used when updating multiple fields from envs #46

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Ensure the updated envs value is used when updating multiple fields from envs #46

merged 1 commit into from
Nov 17, 2023

Conversation

lingyuncai
Copy link
Contributor

Steps to test:

  1. Set func1,func2 to Exported functions
  2. Update the value of -sEXPORTED_FUNCTIONS to _func1,_func2,_func2 in Linker flags

Without the PR:
-sEXPORTED_FUNCTIONS=_func1,_func2,_func2 is updated in Linker flags, which contains the duplicated _func2.

With the PR:
-sEXPORTED_FUNCTIONS=_func1,_func2 is in Linker flags without duplication, which is the expected result.

@lingyuncai lingyuncai added this to the 23WW46 milestone Nov 14, 2023
@lingyuncai
Copy link
Contributor Author

Kindly ping 😄 @NingW101

NingW101
NingW101 approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@NingW101 NingW101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. LGTM~ Thanks

@lingyuncai lingyuncai merged commit abfcfd1 into web-devkits:main Nov 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NingW101 NingW101 NingW101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
23WW46
Development

Successfully merging this pull request may close these issues.
2 participants
@lingyuncai @NingW101