Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the handler for uploaded project icon when publishing package #32

Merged
merged 5 commits into from
Nov 3, 2023

Conversation

NingW101
Copy link
Contributor

Copy link
Contributor

@lingyuncai lingyuncai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to check the equality of config.img and meta.data.webinizer.img at below to see if we need to convert the newly set img value in config.json back to package.json to make the values synced-up in between.

  // project_config.ts - line 737
  set img(v: IProjectIcon | undefined) {
    Object.assign(this.data, { img: v });
    this.save();
    // check here and set back to package.json if needed.
  }

src/project_caches/project_config.ts Outdated Show resolved Hide resolved
src/package_manager/publish.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@lingyuncai lingyuncai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Ning!

@NingW101 NingW101 merged commit 7c66e0e into web-devkits:main Nov 3, 2023
2 checks passed
@NingW101 NingW101 deleted the icon-enhance branch November 20, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants