Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added github link #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Galitie
Copy link
Member

@Galitie Galitie commented Oct 17, 2023

Closes #66

Description

Added github link to main page, opens new tab

Testing

n/a

Type of change

  • Other (please specify)

Screenshots

See issue #66

Checklist:

  • Changes have new/updated automated tests, if applicable
  • Changes have new/updated docs, if applicable
  • I have performed a self-review of my own code
  • I have added comments on any new, hard-to-understand code
  • Changes have been manually tested
  • Changes generate no new errors or warnings

@vercel
Copy link

vercel bot commented Oct 17, 2023

@Galitie is attempting to deploy a commit to the 100devs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@nmpereira nmpereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nmpereira
Copy link
Contributor

@Galitie please merge, should be simple enough to do

@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
100editors ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 8:52pm

@Galitie
Copy link
Member Author

Galitie commented Oct 17, 2023

@nmpereira will merge once ci/ ci test passes... seems to be failing at the build stage...

@alcpereira
Copy link
Contributor

alcpereira commented Oct 17, 2023

@nmpereira unfortunately the Vercel Pro trial has ended and I'm the only member of the team able to allow Preview Deployments.

Note that PR deployments are "nice to have", even for e2e testing you can use a local build.

@nmpereira
Copy link
Contributor

nmpereira commented Oct 17, 2023

@Galitie

I can't get to my setup, so can you try running the build step on your local and see if it's also failing and why?

@Galitie
Copy link
Member Author

Galitie commented Oct 17, 2023

@nmpereira It doesn't build (how I made it build below the error):

Error message:
[0] ⨯ node_modules\convex\dist\esm\react\client.js (51:0) @ new ConvexReactClient [0] ⨯ Error: ConvexReactClient requires a URL like 'https://happy-otter-123.convex.cloud'. [0] at eval (./app/providers/ConvexClientProvider.tsx:10:16) [0] at (ssr)/./app/providers/ConvexClientProvider.tsx (C:\Users\Galit\Documents\100editors\.next\server\app\page.js:228:1) [0] at __webpack_require__ (C:\Users\Galit\Documents\100editors\.next\server\webpack-runtime.js:33:42)

I can make it build, but only if I swap the argument process.env.NEXT_PUBLIC_CONVEX_URL! in app\providers\ConvexClientProvider.tsx on line 5 with http://localhost:3000/

const convex = new ConvexReactClient(process.env.NEXT_PUBLIC_CONVEX_URL!);

I just thought that was a me thing since I might not have access to Convex. Maybe it's not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add github link from website back here so folks/recruiters/hiring can find your code!
3 participants