Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getAlternativeDescriptions can return null #595

Closed
wants to merge 1 commit into from

Conversation

marcriemer
Copy link
Contributor

Target branch: 5.0.x

The alternativeDescriptions property is optional in the constructor, and alternative descriptions are often not present in the fido metadata. This causes issues during deserialization. Therefore, the return of getAlternativeDescriptions() must be optional.

  • It is a Bug fix
  • It is a New feature
  • Breaks BC
  • Includes Deprecations

@Spomky
Copy link
Contributor

Spomky commented Jun 14, 2024

Many thanks.
As this method will be removed in branch 5.0.x, I suggest rebasing on 4.8.x.

@Spomky
Copy link
Contributor

Spomky commented Jun 15, 2024

Resolved with #599. The version 4.8.7 tag will be applied shortly.

@Spomky Spomky closed this Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants