Fixed configuration for authenticator selection criteria

[marcriemer]

Target branch: 4.7.x

• It is a Bug fix
• It is a New feature
• Breaks BC
• Includes Deprecations

Fixed configuration authenticator selection criteria:

• Renamed attachment_mode into authenticator_attachment.

[Spomky]

Hi,

Many thanks for the proposal, but it will break existing applications.
attachment_mode is fine no?

[marcriemer]

Well, yes that's a problem. But it does not work anyway in 4.7.

The parameters is only used for configuration and does not have any effect, other then throwing warning of a missing array element.

Alternative solution would be to change it everywhere else. Even the unit tests use a different parameter name.

I'll look into this again by tomorrow and make a new proposal with the alternative solutions.

[Spomky]

OK I found the reason for this issue.
The modification of the option name is acceptable, but this PR needs to be updated to avoid any BC issue.
I will take care of it.

[nicodemuz]

@Spomky when are you planning to update the READ-ONLY sub-tree split repos?