Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong service call #217

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Wrong service call #217

merged 1 commit into from
Apr 7, 2022

Conversation

Spomky
Copy link
Contributor

@Spomky Spomky commented Apr 7, 2022

Fixes #216

@Spomky Spomky added the bug Something isn't working label Apr 7, 2022
@Spomky Spomky self-assigned this Apr 7, 2022
@Spomky Spomky merged commit dfa5021 into v4.0 Apr 7, 2022
@Spomky Spomky deleted the bugs/wrong-service-call branch April 7, 2022 07:44
@szepeviktor
Copy link
Contributor

@Spomky Do you plan to add a unit test for this?

@Spomky Spomky changed the title Wro g service call Wrong service call Apr 7, 2022
@Spomky
Copy link
Contributor Author

Spomky commented Apr 7, 2022

Hi @szepeviktor,

This is right that the compiler passes are not fully tested. Only during the kernel boot and with one fully featured configuration.
So yes tests could be added to prevent regressions.

@Spomky
Copy link
Contributor Author

Spomky commented Apr 9, 2022

Hi @szepeviktor,

Tests have been added for all Compiler Passes.
See d124cba

@szepeviktor
Copy link
Contributor

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Spomky Spomky

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Symfony 6 - Dependency on a non-existent service "Webauthn\MetadataService\MetadataStatementRepository"
2 participants
@Spomky @szepeviktor