Merge pull request #440 from web-auth/cs/fix-all

Fix Rector+ECS

rector.php

@@ -7,7 +7,7 @@
 use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodParameterRector;
 use Rector\Doctrine\Set\DoctrineSetList;
 use Rector\Php81\Rector\Property\ReadOnlyPropertyRector;
-use Rector\PHPUnit\Rector\Class_\PreferPHPUnitThisCallRector;
+use Rector\PHPUnit\CodeQuality\Rector\Class_\PreferPHPUnitThisCallRector;
 use Rector\PHPUnit\Set\PHPUnitLevelSetList;
 use Rector\PHPUnit\Set\PHPUnitSetList;
 use Rector\Set\ValueObject\LevelSetList;
@@ -43,9 +43,6 @@
         ReadOnlyPropertyRector::class => [
             __DIR__ . '/src/metadata-service/src/Statement/MetadataStatement.php',
         ],
-        ReadOnlyPropertyRector::class => [
-            __DIR__ . '/src/metadata-service/src/Statement/MetadataStatement.php',
-        ],
     ]);
     $config->services()->remove(PreferPHPUnitThisCallRector::class);
     $config->phpVersion(PhpVersion::PHP_81);

src/symfony/src/Security/Authentication/Token/WebauthnToken.php

@@ -31,8 +31,8 @@ public function __construct(
         private ?AuthenticationExtensionsClientOutputs $extensions,
         private readonly string $firewallName,
         array $roles = [],
-        private bool $isBackupEligible = false,
-        private bool $isBackedUp = false,
+        private readonly bool $isBackupEligible = false,
+        private readonly bool $isBackedUp = false,
     ) {
         parent::__construct($roles);
     }

src/webauthn/src/AuthenticatorData.php

@@ -21,7 +21,7 @@ class AuthenticatorData
 
     final public const FLAG_BE = 0b00001000;
 
-    final public  const FLAG_BS = 0b00010000;
+    final public const FLAG_BS = 0b00010000;
 
     /**
      * TODO: remove bits 3 and 4 as they have been assigned to BE and BS in Webauthn level 3.