Do not animate 'display' or the 'animation*' properties. #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewilligers
force-pushed
the
display-not-animated
branch
from
159ed63 to
c704991
Compare
src/normalize-keyframes.js
Outdated
| } | ||
|
|
||
| function isPermittedKeyframeProperty(property) { | ||
| return property !== 'display' && property.lastIndexOf('animation', 0) === -1; |
Contributor
Author
There was a problem hiding this comment.
lastIndexOf(, 0) searches backwards from 0, meaning only one offset is tested. If the property name is long, indexOf needs to check many offsets.
Contributor
|
LGTM with nits. The description should reference the bug it's fixing. |
ewilligers
force-pushed
the
display-not-animated
branch
2 times, most recently
from
2868354 to
e90aa97
Compare
Contributor
|
A test fails. |
Certain properties are not animatable. For example, properties defining animation parameters are not animatable. https://w3c.github.io/web-animations/#concept-not-animatable Web Animations must ignore such properties. This closes web-animations#394
ewilligers
force-pushed
the
display-not-animated
branch
from
e90aa97 to
5eae142
Compare
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.